Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Create tests for MixedBehaviorProfile as_strategy #432

Open
rahulsavani opened this issue Jan 11, 2024 · 1 comment
Open

ENH: Create tests for MixedBehaviorProfile as_strategy #432

rahulsavani opened this issue Jan 11, 2024 · 1 comment
Labels
good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python tests Items which involve the pygambit test suite

Comments

@rahulsavani
Copy link
Member

This issue is about MixedBehaviorProfile.as_strategy, which turns a behavior profile into a MixedStrategyProfile.

There are currently no tests for as_strategy (an old test for this was removed because it was not particularly useful and was even misleading).

New tests should be written for as_strategy. Two that certainly make sense are:

  1. A consistency test that checks that the expected payoff of the original behavior profile matches the expected payoff computed for the mixed strategy that is return by as_strategy.
  2. A reference test that uses manual calculations which implement Kuhn's theorem to convert a behavior strategy to a mixed strategy.
@tturocy
Copy link
Member

tturocy commented Jan 11, 2024

A fortiori we might consider renaming that to as_mixed_strategy_profile or to_mixed_strategy_profile to be more consistent with nomenclature elsewhere.

@rahulsavani rahulsavani added good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python labels Jan 17, 2024
@tturocy tturocy added the tests Items which involve the pygambit test suite label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python tests Items which involve the pygambit test suite
Projects
None yet
Development

No branches or pull requests

2 participants