Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msvc_sink is misleadingly named (works on MinGW as well) #2199

Open
adalisk-emikhaylov opened this issue Dec 2, 2021 · 0 comments
Open

msvc_sink is misleadingly named (works on MinGW as well) #2199

adalisk-emikhaylov opened this issue Dec 2, 2021 · 0 comments
Labels
enhancement v2.x

Comments

@adalisk-emikhaylov
Copy link

msvc_sink seems to work on MinGW as well, so I suggest to rename it to something like win_debug_sink.

We had it disabled in MinGW builds because of the name, not realizing it works there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement v2.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabime @adalisk-emikhaylov