New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMDVM stuck in FM mode on mqtt branch #339
Comments
Hi Andrew
I think your fix is correct. I've incorporated it into the mqtt branch of the MMDVM firmware and I hope that the problem has now gone away. Thanks for finding it.
Jonathan G4KLX
On Friday, 17 November 2023 at 06:13:03 GMT, Andrew Koenig ***@***.***> wrote:
This line causes a feedback loop with MMDVMHost. CFM::reset() is called when MMDVMHost asserts MMDVM_SET_MODE to IDLE, but serial.writeFMStatus() will cause MMDVMHost to assert the mode back into FM. Ultimately this locks the modem in FM mode.
https://github.com/g4klx/MMDVM/blame/a8bf99037ec31546321a6fc69e355f77d9d1aaef/FM.cpp#L391
I commented on the line here in the commit, but this comment is likely not the correct medium, hence the new issue.
7ef0d99#r132809346
73 de KE5GDB
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Hi @g4klx Jonathan ,
Do you think it is a good idea to add default ModeHang (Not Infinity), in firmware or in MMDVMHost? Thank you very much! DE BI7JTA |
Can you try the latest MMDVM firmware, this issue is fixed with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This line causes a feedback loop with MMDVMHost. CFM::reset() is called when MMDVMHost asserts MMDVM_SET_MODE to IDLE, but serial.writeFMStatus() will cause MMDVMHost to assert the mode back into FM. Ultimately this locks the modem in FM mode.
https://github.com/g4klx/MMDVM/blame/a8bf99037ec31546321a6fc69e355f77d9d1aaef/FM.cpp#L391
I commented on the line here in the commit, but this comment is likely not the correct medium, hence the new issue.
7ef0d99#r132809346
73 de KE5GDB
The text was updated successfully, but these errors were encountered: