Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform: change to core entity component #19

Open
g--o opened this issue Oct 12, 2018 · 0 comments
Open

Transform: change to core entity component #19

g--o opened this issue Oct 12, 2018 · 0 comments
Labels
advanced Research and develop according to JSCF's principles improvement refactor Refactoring

Comments

@g--o
Copy link
Owner

g--o commented Oct 12, 2018

Right now it's a property, but we'll want it to be a component.
This will create dependency between components but entity should be free of properties that aren't part of it's definition.

createEntity() will not add transform.
createGameObject() will.

Notes on the decision:

While a lot of engines might force you to keep the transform component, I suggest entity to be an abstract thing, that can exist without any definite location.

Since the core principal of the engine to begin with was extendibility - custom types and scripts can be made only if the entity is abstract as to allow to override update & render, but still provides hirarchy.

When the javascript inheritence concesus will arrive (issue #8 ) we might have actual Game Object that inherits from the abstract entity.

@g--o g--o added improvement advanced Research and develop according to JSCF's principles refactor Refactoring labels Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced Research and develop according to JSCF's principles improvement refactor Refactoring
Projects
None yet
Development

No branches or pull requests

1 participant