Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss pull-based model, since dnfield mentions "... a major architectural change we'd need more time to reason about" #168

Open
fzyzcjy opened this issue Nov 5, 2022 · 2 comments
Open

Discuss pull-based model, since dnfield mentions "... a major architectural change we'd need more time to reason about" #168

fzyzcjy opened this issue Nov 5, 2022 · 2 comments

Comments

@fzyzcjy
Copy link
Owner

fzyzcjy commented Nov 5, 2022 •
edited

1

This is not the only thing that would need peeking,a nd creating this kind of "pull" based model is a major architectural change we'd need more time to reason about. I'm going to close this PR to get it off of review queues for now - tests are not passing and it is not clear that this API is the desirable one to expose to developers to achieve the larger goals you're discussing.

2

I'm going to close this to remove it from review queues. As I'm mentioning in some other PRs, let's discuss further on discord.
@fzyzcjy fzyzcjy changed the title Think and discuss pull-based model Think and discuss pull-based model, since dnfield mentions "... a major architectural change we'd need more time to reason about" Nov 5, 2022
@fzyzcjy fzyzcjy changed the title Think and discuss pull-based model, since dnfield mentions "... a major architectural change we'd need more time to reason about" Discuss pull-based model, since dnfield mentions "... a major architectural change we'd need more time to reason about" Nov 5, 2022
@stale
Copy link

stale bot commented Jan 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Jan 8, 2023

bump

@stale stale bot added the wontfix This will not be worked on label Jan 8, 2023
@stale stale bot closed this as completed Jan 15, 2023
@fzyzcjy fzyzcjy reopened this Jan 15, 2023
@stale stale bot removed the wontfix This will not be worked on label Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fzyzcjy