Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing imports when spreading Impl blocks in multiple files #1933

Closed
kjzl opened this issue May 12, 2024 · 4 comments · Fixed by #1953
Closed

Missing imports when spreading Impl blocks in multiple files #1933

kjzl opened this issue May 12, 2024 · 4 comments · Fixed by #1953
Labels
awaiting Waiting for responses, PR, further discussions, upstream release, etc bug Something isn't working

Comments

@kjzl
Copy link

kjzl commented May 12, 2024

Describe the bug

When having a struct and an Impl for the struct in one file, and another impl for the same struct in another file with 'use' statements which werent made in the other file, they will be missing on the dart side's merged class implementation.

Steps to reproduce

Logs

-

Expected behavior

No response

Generated binding code

No response

OS

No response

Version of flutter_rust_bridge_codegen

No response

Flutter info

No response

Version of clang++

No response

Additional context

No response

@kjzl kjzl added the bug Something isn't working label May 12, 2024
@fzyzcjy
Copy link
Owner

fzyzcjy commented May 12, 2024

Hi, could you please provide an exact minimal reproducible sample?

@fzyzcjy fzyzcjy added the awaiting Waiting for responses, PR, further discussions, upstream release, etc label May 12, 2024
@fzyzcjy
Copy link
Owner

fzyzcjy commented May 13, 2024

Ah I see, then this is a bug. Feel free to PR for it, alternatively I will fix it later! Since this has simple workaround (move the multiple impl block for one single struct in one file), I may not fix it with highest priority.

In addition, I am considering enhancing the parser of use, thus maybe fixing this when doing that is also reasonable.

Copy link
Contributor

github-actions bot commented Jun 2, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting Waiting for responses, PR, further discussions, upstream release, etc bug Something isn't working
Projects
None yet
2 participants