Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support same function name in different files #1944

Merged
merged 33 commits into from
May 18, 2024
Merged

Support same function name in different files #1944

merged 33 commits into from
May 18, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented May 15, 2024

Changes

Close #1913

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy marked this pull request as ready for review May 15, 2024 12:17
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (e1f4e76) to head (e50a59c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1944   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files         369      369           
  Lines       15752    15777   +25     
=======================================
+ Hits        15630    15655   +25     
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 6ca0411 into master May 18, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust function names clashes
1 participant