Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsvg.h using deprecated calls. #974

Open
somiaj opened this issue Mar 24, 2024 · 2 comments
Open

Fsvg.h using deprecated calls. #974

somiaj opened this issue Mar 24, 2024 · 2 comments
Labels
difficulty:easy Issue is suitable for new fvwm developer difficulty:gfi Issue is suitable for a first-time contributor/developer type:bug Something's broken!
Milestone

Comments

@somiaj
Copy link
Collaborator

somiaj commented Mar 24, 2024

Building fvwm gives the following depreciating warnings.

PictureImageLoader.c:287:9: warning: ‘rsvg_handle_get_dimensions’ is deprecated: Use 'rsvg_handle_get_intrinsic_size_in_pixels' instead [-Wdeprecated-declarations]
  287 |         Frsvg_handle_get_dimensions(rsvg, &dim);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from Fsvg.h:9,
                 from PictureImageLoader.c:46:
/usr/include/librsvg-2.0/librsvg/rsvg.h:708:6: note: declared here
  708 | void rsvg_handle_get_dimensions (RsvgHandle *handle, RsvgDimensionData *dimension_data);
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
PictureImageLoader.c:360:9: warning: ‘rsvg_handle_render_cairo’ is deprecated: Use 'rsvg_handle_render_document' instead [-Wdeprecated-declarations]
  360 |         Frsvg_handle_render_cairo(rsvg, cr);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/librsvg-2.0/librsvg/rsvg.h:1452:
/usr/include/librsvg-2.0/librsvg/rsvg-cairo.h:88:10: note: declared here
   88 | gboolean rsvg_handle_render_cairo (RsvgHandle *handle, cairo_t *cr);
      |          ^~~~~~~~~~~~~~~~~~~~~~~~

This will require a little bit of refactoring how fvwm computes SVG sizes.

@somiaj somiaj added the type:bug Something's broken! label Mar 24, 2024
@ThomasAdam
Copy link
Member

Note to self: The SVG version checking will need to be ripped out as well...

@ThomasAdam ThomasAdam changed the title Fsvg.h using depericated calls. Fsvg.h using depricated calls. Mar 30, 2024
@ThomasAdam ThomasAdam changed the title Fsvg.h using depricated calls. Fsvg.h using deprecated calls. Apr 3, 2024
@ThomasAdam ThomasAdam added this to the 1.1.1 milestone Apr 3, 2024
@ThomasAdam ThomasAdam added difficulty:easy Issue is suitable for new fvwm developer difficulty:gfi Issue is suitable for a first-time contributor/developer labels Apr 3, 2024
@ThomasAdam
Copy link
Member

See also this migration guide: https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/doc/migrating.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:easy Issue is suitable for new fvwm developer difficulty:gfi Issue is suitable for a first-time contributor/developer type:bug Something's broken!
Projects
Status: To do
Development

No branches or pull requests

2 participants