Feature Request: Implement activation strategies

[aneeshrelan]

I see that the current library only supports a default toggle on/off activation strategy. It'll be really cool to implement different activation strategies to have granular control on the React app. Thoughts?

[fvoordeckers]

For sure! Just not sure about the timeframe yet.

[aneeshrelan]

If possible, can I try contributing here for an initial set of strategy?

[fvoordeckers]

Please do, would be really great. Feel free to create a merge request.
For the next few months I will not be able to fully integrate this.

If you add a MR, I'll be happy to review, merge and release it.

[aneeshrelan]

Thanks! I'll try to get up something in a few weeks, even I'm caught up with other work, but honestly I need this for a project so I should be able to get an initial one

[aneeshrelan]

Please assign this to me

[saborrie]

For anyone who ends up here, just know that you can still use this library and add the strategies on top yourself:

import { useFlag } from "react-unleash-flags";
import useCurrentUser from './hooks/useCurrentUser'; // write your own custom hook to get the logged in user

// this useFlagIsEnabled returns boolean, so its not the same as consuming useFlag directly
export function useIsFlagEnabled(s) {
  const currentUser= useCurrentUser();
  const f = useFlag(s);

  if (f?.enabled !== true) return false;

  // example implementation of userWithId strategy
  for (let strategy of f.strategies) {
    switch (strategy.name) {
      case "default":
        return f.enabled;
      case "userWithId": {
        if (strategy.parameters.userIds.includes(currentUser?.id)) return true;
        break;
      }
      // TODO you can add all the strategies you use here
    }
  }

  return false;
}

export function FeatureFlag({ name, children }) {
  const enabled = useIsFlagEnabled(name);

  if (enabled) return children;
  return null;
}

[fvoordeckers]

@saborrie Good point! The idea is to provide a set of basic strategies in the feature (id or % rollout ...)