Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

RFE: Please link to an explorer when listing addresses and transactions #53

Open
kfiresmith opened this issue Jan 30, 2018 · 5 comments

Comments

@kfiresmith
Copy link
Collaborator

Hi @johansten,
Great wallet so far. Hopefully this change is small enough that it can make it into a minor release, but it would be swell if any time that the wallet displays an address or transaction ID, that the resource being displayed was itself a hyperlink to the information page on https://stellarchain.io/ for the resource.

https://stellarchain.io/tx/some_transaction_ID
https://stellarchain.io/address/some_address

Thanks!

@kfiresmith kfiresmith changed the title Please link to an explorer when listing addresses and transactions RFE: Please link to an explorer when listing addresses and transactions Jan 30, 2018
@orbitlens
Copy link

orbitlens commented Feb 1, 2018

Agree with @kfiresmith regarding the concept, but I vote for https://stellar.expert block explorer 😉

https://stellar.expert/explorer/tx/{tx_id}
https://stellar.expert/explorer/account/{tx_id}

@kfiresmith
Copy link
Collaborator Author

Hi @orbitlens! Thanks so much for taking the time to post. You don't happen to write javascript do you? For the app I think the ideal might be to have a default lookup destination (stellar.expert, stellarchain.io, etc), but have it be toggle-able by radio button. I suppose a wallet probably should not pick winners. :)

It would be really swell to get any destination working at this point.

@kfiresmith
Copy link
Collaborator Author

Hi again @orbitlens! I started thinking about the conundrum of choosing an explorer and how to do that fairly. I decided to run page load tests that judge load time and page contents size. Here are some stats for an address page:

https://stellarchain.io/address/GB5BX7BS2OS63UDICM5FIO3J24UTYIYHL6YOH222JEM3VHIJ3ELWP2IG:
1.22s load time
447.5KB page size
17 requests

https://stellar.expert/explorer/account/GB5BX7BS2OS63UDICM5FIO3J24UTYIYHL6YOH222JEM3VHIJ3ELWP2IG
1.96s load time
2.6MB page size
5 requests

So, my next question is: Have you considered creating a trimmed down display to be presented based on user agent or optionally via a custom URL scheme, eg: "/?minimal"

Thanks again!

@orbitlens
Copy link

You see, StellarExpert is a single-page app built on React, so the bundle includes all views and logic for all pages plus React runtime. I can decrease the resulted size to approximately 1.5 MB, but that's it.

On the other side, StellarChain loads all resources on each request. Meantime, StellarExpert does not reloads all bundles on navigation, only ledger data is fetched. Therefore if you navigate to TX and than click an address link, StellarExpert shows the second page immediately.

Again, I don't think that page load time is the best metric for comparison. It's all about the functionality. For example, compare https://stellarchain.io/ledger/7841 and https://stellar.expert/explorer/ledger/7841. Stellarchain shows only first operation within transaction while it actually contains 3 operations. Not to mention such things as full account history and visualization charts.

If you have any further questions regarding StellarExpert, welcome to the issue tracker. Let's not distract @johansten with off-topic discussions.

@kfiresmith
Copy link
Collaborator Author

Thanks for the reply! Interesting things to consider. My main concern was with the app being for mobile as well as desktop, more than a few hundred KB could potentially be pretty costly in some locales, or slow on 3G. It was an off-the-cuff and shallow evaluation of the potential impacts of loading a page from either explorer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants