You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What's the point of the IMapsterConverter interface? It is now used only by OrderByConverter which doesn't seem to have anything to do with Mapster.
There's also IMapsterConverterAsync which is only used by MappedPaginatedResultConverter, but that seems to be an implementation detail of the ToMappedPaginatedResultAsync extension method and should probably be private (in that case the code in the ConvertBackAsync method of the MappedPaginatedResultConverter can as well be implemented directly into the extension method in stead of using the converter class which makes things more complicated IMHO).
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
What's the point of the
IMapsterConverter
interface? It is now used only byOrderByConverter
which doesn't seem to have anything to do with Mapster.There's also
IMapsterConverterAsync
which is only used byMappedPaginatedResultConverter
, but that seems to be an implementation detail of theToMappedPaginatedResultAsync
extension method and should probably be private (in that case the code in theConvertBackAsync
method of theMappedPaginatedResultConverter
can as well be implemented directly into the extension method in stead of using the converter class which makes things more complicated IMHO).I might be missing something?
Beta Was this translation helpful? Give feedback.
All reactions