New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URI path present in _GET / Input::get() in case of PHP7+fpm #2167
Comments
Indeed, it should have been caught. |
Thanks for a quick response! fuel/fuel@60e4690 Anyway, removing it is fixing the issue for me (in 1.8)... I was trying it before, but due to some configuration option on our server it didn't work... |
It works in 8.0 too. |
Maybe I was not clear enough in above comment, so here is full explanation: Removing "QSA" doesn't change anything in regard of URI path in GET What fixes the issue for me (in Fuel release version) is removing the question mark from the rewrite rule, ie.:
with this rule URI path is NOT present in
BTW: in current Fuel dev the URI path is still present in By "Fuel release" I mean code installed by instructions from https://fuelphp.com/docs/installation/instructions.html#/from_github - "Clone the latest release from github", git+composer version. By "Fuel dev" I mean code installed by instructions from https://fuelphp.com/docs/installation/instructions.html#/from_github - "Clone the latest development branch from github", git+composer version. Tested (among others) on current Arch Linux, PHP7 with FPM. |
See https://github.com/bartlomiejb/for-fuel-core-issue-2167/tree/main/archlinux/etc I installed packages for PHP7 as that's the version that I am interested in ;)
With this config and these packages the results of
Fuel Dev:
Have you tried also with PHP7?
Try omitting query params - from my tests on PHP7 the bug (ie. URI path) was not present when there were query params. |
After migrating our apps to a newer server software we noticed that there is an URI path in _GET now sometimes (when there is no query params in URL proper).
For example lets modify an example initial Fuel app (
welcome.php
controller):After visiting
http://domain/hello
we get:The culprit is the rule in
.htaccess
:https://github.com/fuel/fuel/blob/1.9/develop/public/.htaccess#L66
I guess the fix for this should be in Fuel core somewhere... Or maybe you have another idea?
From the application programmer point of view it shoud work just the same as it was the case of another server software (eg. PHP5 or PHP7+sapi), ie. no "garbage" in _GET :-)
The text was updated successfully, but these errors were encountered: