Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\Fuel\Core\Cache_Storage_Driver::get_content_handler - always false cond #2128

Open
Illirgway opened this issue Sep 25, 2019 · 1 comment
Open

Comments

@Illirgway
Copy link
Contributor

https://github.com/fuel/core/blob/1.9/develop/classes/cache/storage/driver.php#L382

		// When not yet set, use $handler or detect the preferred handler (string = string, otherwise serialize)
		if (empty($this->content_handler) && empty($handler))    // (1)
		{
			if ( ! empty($handler))    // (2)
			{

Due to (1), empty($handler) in (2) is always true, so cond is always false and never fire. I can't understand exactly what this code should do so i can't write fix commit, only issue

@Illirgway
Copy link
Contributor Author

Illirgway commented Sep 25, 2019

if I understand correctly, (2) should simple be moved above (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant