Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockingStrategy is Broken #36

Open
tvdijk opened this issue Mar 24, 2017 · 0 comments
Open

BlockingStrategy is Broken #36

tvdijk opened this issue Mar 24, 2017 · 0 comments

Comments

@tvdijk
Copy link

tvdijk commented Mar 24, 2017

Sequencer and SequenceBarrier each have their own wait strategy instance. This works for the other wait strategies, because they don't carry state. However, BlockingStrategy has a mutex and a condition variable, and relies on the Sequencer to signal it when an event is published, which is supposed to wake up a SequenceBarrier that is being waited on.

This signalling currently has no effect because the Sequencer is signalling a different instance of BlockingStrategy (and thus condition variable) than the SequenceBarrier is waiting on. These two classes should be sharing the same instance of BlockingStrategy. I see no way of doing that in the code currently.

PWisPeterWang pushed a commit to PWisPeterWang/disruptor-- that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant