-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto buy bnb when it is below a certain threshold #5562
Comments
it's currently not implemented, and i don't see a big deal in buying enough manually. Feel free to impement if you think it's a must (i don't think so) |
Also interested by this feature, I will try to look into it if no one does it before.
The bot would buy up to 1% of the stake if it drops below 0.5%. What do you think? |
i'd make it absolute BNB to be honest. you'll not need an insane amount of BNB ... just enough to keep the bot paying for it in BNB. |
Well then I would lower the ratio to 0.15% for instance. In Binance, the fees are 0,075% in BNB for each trade, so assuming you buy then sell all your stake it would cost about 0,15% of your stake in BNB. Maybe we could provide both solution (percentage and fixed amount) with amount advices of default values. Indeed, a 1% stake amount is way too much for this use case. Edit: I just checked how some other exchanges behave.
So according to these examples this feature would be really useful for Binance and Kucoin only. And I would stay on the percentage strategy with a default values table, eg. 0.15% for BInance and 0.16% fur Kucoin. For FTX you should only buy a fixed amount of FTT and a huge amount (at least 100$ to a 3% discount, 1000$ for 5% discount, 100k$ for a 25% discount like Binance lol). And FTT is not used to pay fees so there is no point using this auto buy feature for FTX. Example of config.json:
Don't know if it makes sense. Some user could use this feature in another way, ie having a part of they wallet holding another currency (BTC, ETH...) We could as well make a list of coins the bot would buy up to a set threshold. Edit 2021-11-06: Anyone, feel free to contribute, I don't feel I'll do it in the next few months. |
having a "list of currencies" will not make much sense - as you'll have only one fee currency. to be fair - if your bot compounds form 1000$ to 100.000$ - you'll have other problems if you never changed any parameters (like increasing parallel trades). (trades will not fill, or you'll move the market if using market orders). the problem is - most people won't think about 100_000$ - but about a 1000$ (or even 100$) wallet. in the end - i think these are details though which we can work out as part of the work on a Pull Request. |
This one seems a bit complicated for me. I have another suggestion in the meantime: when the BNB amount is too low, a line should be added to the Telegram answers to some commands, only when specified on the config file.
|
Forgive me if this doesn't make sense, but is it possible to buy the BNB at the time of the trades that you would need it for? It seems that the proposed solutions are buying the BNB percentage when you're running low however whilst looking into this issue I pondered the idea of simply buying it based on the actual trade amount. Unless I'm mistaken it's always the same percentage as per: |
@NoahGago that won't be possible (at least not buying just the amount necessary). Fees are usually 0.1% of a trade - that's 1$ for a 1000$ trade. Minimum trade amounts are usually around 10-12$ (depending on market fluctuation, among others) - so you can't buy "what you need" - but you must buy it "up front" - or rather, accept to keep it around for some time. While this won't exclude "buy when needed" - i think we need to be careful with timing here - adding a call (and waiting for the order to fill) right before a trade can mean you've wasted the opportunity, unless you're going for market orders (even then, you'll potentially be a few seconds later than without this, as you're now making 2 (or 3) additional network calls - all while you'd really wanted to buy BTC. |
To be honest, i'm not convinced that this is a "good first issue" for new contributions, and might potentially lead to frustrations in the process (i don't think this is an easy feature to contribute). I'd not focus it on binance alone - as other exchanges have their own Fee coins too, so ideally, the implementation would be exchange-agnostic for the most part (and therefore more likely in |
This is good feature
Percents are better than absolute, because deposit can change |
+1 for keeping auto trading in the long term. |
Is it possible to add functionality to auto buy bnb for trading fee when the bnb balance is below a certain value?
Thank you
The text was updated successfully, but these errors were encountered: