Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type def might be missing 'overlay' for OverflowXProperty #62

Open
nick-gaudreau opened this issue Jan 1, 2019 · 4 comments · May be fixed by #179
Open

type def might be missing 'overlay' for OverflowXProperty #62

nick-gaudreau opened this issue Jan 1, 2019 · 4 comments · May be fixed by #179
Labels
MDN Issue or PR is filed to MDN

Comments

@nick-gaudreau
Copy link

export type OverflowXProperty = Globals | "auto" | "clip" | "hidden" | "scroll" | "visible";

I think its not the only one that should have the 'overlay' property. With material UI when assigning style using JS for overflowX: "overlay" I would get a type error.

Manually did this fix my issue in csstype/index.d.ts:
export type OverflowXProperty = Globals | "auto" | "clip" | "hidden" | "scroll" | "visible" | "overlay";
@frenic
Copy link
Owner

frenic commented Jan 3, 2019 •
edited

The overlay value is deprecated and therefore not included. What you can do to get rid of the type error is to do: { ['overflowX' as any]: 'overlay' } as described in the docs. I hope it helps.

@nick-gaudreau
Copy link
Author

Nice thx - I didn't think of casting it

@EvanHahn-Signal
Copy link

To quote MDN:

Only supported in WebKit-based (e.g., Safari) and Blink-based (e.g., Chrome or Opera) browsers.

It doesn't look like the value is deprecated, just nonstandard. Should it be added and this issue reopened?

@frenic frenic reopened this Nov 15, 2021
@frenic frenic added the MDN Issue or PR is filed to MDN label Nov 15, 2021
@layershifter layershifter mentioned this issue Mar 31, 2022
Merged
@quantizor quantizor mentioned this issue Oct 6, 2022
Closed
@erictuvesson
Copy link

What is the status on this issue?

@frenic frenic linked a pull request Apr 1, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MDN Issue or PR is filed to MDN
Projects
None yet
Milestone
No milestone
4 participants
@frenic @erictuvesson @nick-gaudreau @EvanHahn-Signal