Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default shortcut for Firefox in Linux #279

Closed
wants to merge 1 commit into from
Closed

Change default shortcut for Firefox in Linux #279

wants to merge 1 commit into from

Conversation

coaxial
Copy link

@coaxial coaxial commented Mar 25, 2023

Close #241

@fregante
Copy link
Owner

Thanks for the PR, but the suggestion was to drop the default shortcut altogether. However this requires further work to preserve it for existing installations. See:

The next step is to remove this default, then iodate the code from the previous PR to:

  1. get the saved shortcut from storage
  2. set it back via chrome.commands API

The intent is:

  • new users will not have command set because the manifest won't specify one
  • old users will keep whatever was saved in memory before

@fregante fregante marked this pull request as draft March 25, 2023 15:21
@coaxial
Copy link
Author

coaxial commented Mar 25, 2023

I see. When I opened the issue, I was only suggesting to change the default shortcut so it doesn't conflict with any existing one in Firefox.

I'll close this PR then as it doesn't do what you're planning.

@coaxial coaxial closed this Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default extension shortcut conflicts with existing Firefox default shortcut
2 participants