Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass full URL to editor for major mode detection #212

Open
mbunkus opened this issue Jul 29, 2021 · 1 comment
Open

Pass full URL to editor for major mode detection #212

mbunkus opened this issue Jul 29, 2021 · 1 comment

Comments

@mbunkus
Copy link

mbunkus commented Jul 29, 2021

Setup

Browser: Chrome, Vivaldi
Editor: Emacs

Description

I'm trying out GT with atomic-chrome in Emacs. Unfortunately matching the major mode against host names isn't enough for me. Emacs is my primary tool at work, and we run all of our web services through a single reverse proxy, meaning all of them share the same host name. A lot of those require different major modes: a ticketing system (text-mode), a wiki (dokuwiki-mode), a local Gitlab instance (markdown-mode), our ERP system (a custom-made, ERP-specific major mode) etc.

Coming from the "Edit with Emacs" extension I could handle all of them just fine as Emacs had access to the full URL. With GT this is impossible and highly annoying. Detecting the major mode from the contents doesn't work either as a lot of the time there is no initial content.

So please consider a way to provide the full URL or at least the path, too (meaning up to ?; that would definitely suffice for me). Thanks.

@jamesramsay
Copy link

jamesramsay commented Nov 12, 2021

I noticed this too while implementing a server according to the protocol which says url is a URL. Currently the extension only sends the host (e.g. gitlab.com).

I have only tested Chrome with GhostText 21.4.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants