Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframes work but the tab state isn't handled correctly #204

Open
fregante opened this issue Feb 25, 2021 · 0 comments
Open

Iframes work but the tab state isn't handled correctly #204

fregante opened this issue Feb 25, 2021 · 0 comments

Comments

@fregante
Copy link
Owner

  • The content script is injected in every document simultaneously but when selecting a field in an iframe, the outer frame keeps listening
  • The fields in the iframe don't seem to be highlighted
  • The "connected field count" in the browser action is managed separately by each content script, so they end up overriding each other
  • alreadyInjected is only considered for the top-frame, but this should be handled for each frame (e.g. if you activate GT, then the iframe changes page, it will appear alreadyInjected but the iframe doesn't have any content scripts)

This is a rather complex issue and will probably require rewriting the injection logic once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant