Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use a temporary directory when downloading files and replies #2005

Open
cfm opened this issue May 13, 2024 · 1 comment
Open

always use a temporary directory when downloading files and replies #2005

cfm opened this issue May 13, 2024 · 1 comment
Labels
proxy v2 ♻️ Refactoring This PR is a strict refactoring.

Comments

@cfm
Copy link
Member

cfm commented May 13, 2024

Description

Rather than defaulting to either ~/QubesIncoming or ~/Downloads or taking an explicit path only under test, API.download_{reply,submission}() should always save a file to a temporary directory provided by the caller.

How will this impact SecureDrop users?

No user-facing impact.

How would this affect the SecureDrop Workstation threat model?

No threat-model implications.

@cfm cfm added the ♻️ Refactoring This PR is a strict refactoring. label May 13, 2024
@cfm
Copy link
Member Author

cfm commented May 14, 2024

One reason to make this change is so that the branch (code-path) we test is actually the branch we care about, as demonstrated by the test-level changes in 18e19c3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proxy v2 ♻️ Refactoring This PR is a strict refactoring.
Projects
None yet
Development

No branches or pull requests

2 participants