Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused securedrop-log implementations #1998

Closed
cfm opened this issue May 9, 2024 · 1 comment · Fixed by #2014
Closed

remove unused securedrop-log implementations #1998

cfm opened this issue May 9, 2024 · 1 comment · Fixed by #2014
Labels
🏖️ Summer cleanup

Comments

@cfm
Copy link
Member

cfm commented May 9, 2024

Let's remove:

  1. securedrop-log, which nothing in either securedrop-client or securedrop-workstation appears to invoke; or
  2. securedrop_log, which nothing in either securedrop-client or securedrop-workstation appears to load.

I've discovered this before as well, and came to the same conclusion. If you look at the first commit to securedrop-log (9ff16b6), the original idea was that clients directly log to the VM via a custom log handler, but that was dropped later on in favor of rsyslog (see freedomofpress/securedrop-log#7 and 29c1cf7), but the old approach was never deleted.

Originally posted by @legoktm in #1995 (comment)
@cfm cfm mentioned this issue May 9, 2024
Merged
@deeplow
Copy link
Contributor

deeplow commented May 13, 2024

We also need to remove ex1.py, ex2.py, example.py and journal-example.py which depend on it but don't seem to be used for anything else.

legoktm added a commit that referenced this issue May 17, 2024
@legoktm
Remove unused securedrop-log code
a117e00 
If you look at the first commit to securedrop-log (9ff16b6), the
original idea was that clients directly log to the VM via a custom log
handler, but that was dropped later on in favor of rsyslog (see
<freedomofpress/securedrop-log#7> and
29c1cf7), but the old approach was never deleted.

This removes that old approach was well as example code.

Fixes #1998.
@legoktm legoktm mentioned this issue May 17, 2024
Merged
12 tasks
legoktm added a commit that referenced this issue May 17, 2024
@legoktm
Remove unused securedrop-log code
04ed4b5 
If you look at the first commit to securedrop-log (9ff16b6), the
original idea was that clients directly log to the VM via a custom log
handler, but that was dropped later on in favor of rsyslog (see
<freedomofpress/securedrop-log#7> and
29c1cf7), but the old approach was never deleted.

This removes that old approach was well as example code.

Fixes #1998.
legoktm added a commit that referenced this issue May 23, 2024
@legoktm
Remove unused securedrop-log code
588988a 
If you look at the first commit to securedrop-log (9ff16b6), the
original idea was that clients directly log to the VM via a custom log
handler, but that was dropped later on in favor of rsyslog (see
<freedomofpress/securedrop-log#7> and
29c1cf7), but the old approach was never deleted.

This removes that old approach was well as example code.

Fixes #1998.
@cfm cfm closed this as completed in #2014 May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏖️ Summer cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused securedrop-log code freedomofpress/securedrop-client
2 participants
@cfm @deeplow