Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproducible VCR cassettes #1992

Open
cfm opened this issue May 7, 2024 · 0 comments
Open

reproducible VCR cassettes #1992

cfm opened this issue May 7, 2024 · 0 comments
Labels

Comments

@cfm
Copy link
Member

cfm commented May 7, 2024

Description

As of #1718, running make regenerate-sdk-cassettes does exactly that. But the result is basically unreviewable (e.g., 1f3c2c8). It would be nice to be able to set seed values for both the Server (Journalist API) and Client (SDK) sides of the SDK test suite, such make regenerate-sdk-cassettes could be diffed meaningfully.

@legoktm and I discussed this last night and I agreed that we'd like it. We didn't reach a conclusion on either (a) whether it's feasible or (b) whether it's worth doing.

How will this impact SecureDrop users?

No user-facing changes.

How would this affect the SecureDrop Workstation threat model?

No security implications.

User Stories

As developer going back and forth between the Server/API and Client/SDK, I would like to be able to use make regenerate-sdk-cassettes to diff the interaction between the two, not just blanketly commit the giant YAML blobs that come back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant