Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete (source / conversation) hotkeys from main panel #1897

Open
rocodes opened this issue Mar 8, 2024 · 1 comment
Open

Delete (source / conversation) hotkeys from main panel #1897

rocodes opened this issue Mar 8, 2024 · 1 comment

Comments

@rocodes
Copy link
Contributor

rocodes commented Mar 8, 2024

Description

Per user request: deletion is slow and requires lots of clicks. As a precursor to multi-select / multi-delete, support a hotkey that triggers the DeleteSource and/or DeleteConversation action for the source that is currently selected in the main panel.

How will this impact SecureDrop users?

How would this affect the SecureDrop Workstation threat model?

No change assuming the deletion confirmation modal is what is triggered

User Stories

As a user, I want to be able to perform repetitive actions with as few mouse clicks as possible.

@tomcardoso
Copy link

tomcardoso commented Mar 8, 2024

Further to this: at The Globe right now we deal with a lot of spam in our SecureDrop instance. The first 20 minutes or so of every session are spent deleting "tips" that are anything but. I've become very familiar with the source deletion button.

It takes four clicks to delete: one to select the message, a second on the three dots at top right, a third to select "delete source," and a fourth to confirm the modal. I've experienced a few issues with this workflow:

  1. The client locks up when I'm deleting, meaning my clicks (such as to select the next message for deletion) aren't registered. I have to wait until some previous action (a deletion, or a message loading/decrypting) completes.
  2. I figured out I could save myself a click on the confirmation modal by using the directional keys and enter/return. In theory, once the modal is open, I should be able to hit the right key, then enter to confirm deletion. But occasionally the confirmation modal doesn't have focus when I try to do this, meaning I still need to mouse over and click. I suspect it's related to the client locking issue.
  3. Regarding the message list in the left-hand column: I've learned that it's best to delete from the bottom (oldest) message up, instead of from the most recent down, because if I start working from the top and move down, the client locking/delays mean that I accidentally end up selecting the wrong message as the list updates and rearranges itself. This probably wouldn't be an issue if there wasn't such a delay for a message to disappear once I've confirmed its deletion.
  4. The four-click process can be a bit dangerous, because once I get into a groove and am more or less deleting on autopilot, it's all too easy to click on the wrong message (because of item no. 3 above) and delete the wrong message. I've come close a few times but have always caught myself, but feel like it's only a matter of time before I delete an actual, valuable tip.

For all those reasons, I think a hotkey would be nice. That said, I wonder if there are other ways we could delete? Could I delete directly from the left-hand column somehow? The interface already has that star mechanism. Maybe a trash can could appear if you hover over the far right side of a row in the list view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants