Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support duplicate HTTP headers #1780

Open
cfm opened this issue Jan 31, 2024 · 2 comments
Open

support duplicate HTTP headers #1780

cfm opened this issue Jan 31, 2024 · 2 comments
Labels

Comments

@cfm
Copy link
Member

cfm commented Jan 31, 2024

Description

During #1778, I've been reminded that HTTP permits both requests and responses to have duplicated headers—that is, to have multiple values for the same key. We should make that securedrop-proxy supports these cases at least as well as suggested by VCR.py's HeaderDict.

@cfm cfm added the proxy v2 label Jan 31, 2024
@legoktm
Copy link
Member

legoktm commented Feb 5, 2024

For prioritization purposes, is there any place we currently use or expect duplicate headers?

reqwest also has a HeaderMap type for this reason (see https://docs.rs/reqwest/latest/reqwest/header/struct.HeaderMap.html#method.get_all), we would need to change the type we serialize to to probably HashMap<String, Vec<String>>.

@cfm
Copy link
Member Author

cfm commented Feb 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants