Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Item Tax Rate #41081

Open
vorasmit opened this issue Apr 18, 2024 · 0 comments
Open

Issues with Item Tax Rate #41081

vorasmit opened this issue Apr 18, 2024 · 0 comments
Labels

Comments

@vorasmit
Copy link
Contributor

vorasmit commented Apr 18, 2024

Introduction

Item tax rate is a field that's updated in items table (eg: Sales Invoice Item) and used to update total taxes.

Workflow: Item Tax Template => Updates Item Tax Rate => Updates Final Taxes.

Hence it's crucial to ensure Item tax template and Item tax rate are consistent.

eg: Item Tax Rate:
{"Output Tax SGST - RT": 6.0, "Output Tax CGST - RT": 6.0, "Output Tax IGST - RT": 12.0, "Input Tax SGST - RT": 6.0, "Input Tax CGST - RT": 6.0, "Input Tax IGST - RT": 12.0, "Input Tax SGST RCM - RT": 6.0, "Input Tax CGST RCM - RT": 6.0, "Input Tax IGST RCM - RT": 12.0}

Issues

We found following two cases where it's inconsistent.

Item tax rate is only updated in UI and not backend.

Reference: Function: get_item_tax_info

This causes issues when trying to use data import tool to import transactions.

Item tax rate is set even after Item Tax Template is removed

Steps on how to replicate this issue

  • Create one item with only one item tax template
  • Create a transaction for this item. This should auto-fetch item tax template.
  • Unset item tax template from the item. Save

With unset, it doesn't unset item tax rate, causing incorrect final taxes.

Module

accounts

Version

Frappe & ERPNext Develop

Installation method

None

Relevant log output / Stack trace / Full Error Message.

No response

@vorasmit vorasmit added the bug label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Shortlisted
Development

No branches or pull requests

1 participant