Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl support in shared elements #213

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

rtl support in shared elements #213

wants to merge 1 commit into from

Conversation

alikazemkhanloo
Copy link

@alikazemkhanloo alikazemkhanloo commented Sep 3, 2019 •
edited

This will fix the jumping element while transitioning in RTL, closes #203.
There is another file named getAnchoredElements.js with similar code, should this fix apply to that file too? how can I test it?

P.S the anchor props works fine no need to change getAnchoredElements.js

@alikazemkhanloo
Copy link
Author

alikazemkhanloo commented Feb 21, 2020 •
edited

this is working, could someone please merge this PR?

EDIT: I didn't know I opened this PR earlier myself :))

@saurabh874
Copy link

saurabh874 commented May 18, 2021 •
edited

@alikazemkhanloo correct. this is perfectly working for RTL.
@chrfalch @jaulz can you please merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfalch chrfalch Awaiting requested review from chrfalch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTL support
2 participants
@alikazemkhanloo @saurabh874