feat: Add support for inbound webhooks that use form data #1998
+119
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BolajiOlajide
commented
May 7, 2024
| @@ -37,3 +37,6 @@ typesense_data | |||
| postgres_data | |||
| redis_data | |||
| /.run/go test github.com_frain-dev_convoy_server.run.xml | |||
|
|
|||
| convoy-ee | |||
There was a problem hiding this comment.
I'm happy to remove this, however I added this because it is an artifact introduced by the make build command and since it's user-generated, it thus makes sense that it is ignored by default.
|
|
|
Shouldn't the JOSN payload received at the endpoint be this? {
"name": "legbegbe",
"error": "no error",
"status": "success"
} |
@jirevwe You're right. However, I did it that way because the return type of FormData is actually a map of the structure |
|
@jirevwe Updated.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1987
This PR adds support for inbound webhooks that send data via
form-data. It defaults toJSONwhen the content type isn'tmultipart/form-datato avoid introducing a breaking change. As time goes one, we'll want to add support forwww-url-encoded.