Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML ARIA roles #548

Open
johanbove opened this issue Dec 7, 2020 · 2 comments
Open

Add HTML ARIA roles #548

johanbove opened this issue Dec 7, 2020 · 2 comments

Comments

@johanbove
Copy link
Contributor

johanbove commented Dec 7, 2020

What's the problem you want solved?

Was looking at the HTML DOM of the Oasis source and I really believe Oasis is probably the most accessible client to access Scuttlebutt. This should be high-lighted more. What we would need is HTML ARIA roles to the HTML elements. Also, a question: why isn't the first div in the header element of content entries an h2 or h3 element? This would make the "reader view" rendering in Firefox better as the header for each content article would come out better.

Is there a solution you'd like to recommend?

I would like to extend the rendered HTML elements with relevant ARIA roles.

@johanbove johanbove changed the title Make this the most accessible SSB client Make Oasis the most accessible SSB client Dec 7, 2020
@black-puppydog
Copy link
Collaborator

Can confirm that replacing div by h2 does help the reader view, even though of course it slightly breaks the current styling.
@johanbove do you have experience with accessibility? Is the reader view a good proxy for this? Seems pretty neat. :)

@Powersource Powersource changed the title Make Oasis the most accessible SSB client Add HTML ARIA roles Dec 14, 2020
@johanbove
Copy link
Contributor Author

Well, we should not just add HTML aria roles and call it a day as is explained in this excellent video by Heydon Pickering: https://briefs.video/videos/what-is-aria-even-for/
What is needed is a review of the used HTML in OASIS and add the ARIA roles whenever we cannot solve it with using semantic HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants