Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated html_part breaking tests after upgrade to 1.11.0 #290

Open
sajan45 opened this issue Feb 28, 2024 · 0 comments
Open

Generated html_part breaking tests after upgrade to 1.11.0 #290

sajan45 opened this issue Feb 28, 2024 · 0 comments

Comments

@sajan45
Copy link

sajan45 commented Feb 28, 2024

After upgrading to 1.11.0 from 1.10.3, assertions in my app is breaking. The only difference is email.html_part.body.to_s gives an HTML with a \r at the end of each line. I think this is the PR #248 that changed how html_part is generated. We use Rails 7.0.8, premailer 1.22, and standard ERB files for mailer views, nothing unusual that I can see. I don't know what other info could be helpful. Please let me know if you need any other details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant