Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same behavior as major client's tx pool (e.g., geth, nethermind) for stricter tests #7897

Open
colinlyguo opened this issue May 9, 2024 · 0 comments
Open

Same behavior as major client's tx pool (e.g., geth, nethermind) for stricter tests #7897

colinlyguo opened this issue May 9, 2024 · 0 comments
Labels
T-feature Type: feature

Comments

@colinlyguo
Copy link

colinlyguo commented May 9, 2024 •
edited

Component

Anvil

Describe the feature you would like

It's nice to have the same behavior (e.g., constraints when replacing a transaction) as major clients' tx pool (e.g., geth, nethermind) so that dev components that pass tests based on Anvil's can be smoothly deployed in production.

Additional context

some constraints like (at least 100% when replacing a blob transaction):
geth: https://github.com/ethereum/go-ethereum/blob/93c541ad563124e81d125c7ebe78938175229b2e/core/txpool/blobpool/blobpool.go#L1145-L1150
nethermind: https://github.com/NethermindEth/nethermind/blob/bf658d8525d8b1b3007c49ddc38b12a061e033a2/src/Nethermind/Nethermind.TxPool/Comparison/CompareReplacedBlobTx.cs#L30-L32
@colinlyguo colinlyguo added the T-feature Type: feature label May 9, 2024
@colinlyguo colinlyguo changed the title Same behavior as major client's tx pool (e.g., geth) for stricter tests Same behavior as major client's tx pool (e.g., geth, nethermind) for stricter tests May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colinlyguo