Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unsed Css for increasing performance ( with little formatting ) #1447

Closed
wants to merge 3 commits into from
Closed

Removing unsed Css for increasing performance ( with little formatting ) #1447

wants to merge 3 commits into from

Conversation

subhahu123
Copy link
Contributor

@subhahu123 subhahu123 commented Jan 30, 2019 •
edited

Fixes #1448

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

  • removing the extra and unused css.
  • web app is working absolutely fine . i have it fully each and every section ( in my concern )
  • removing extra css is not affecting the website in any manner.
  • increasing lighthouse performance

@codecov
Copy link

codecov bot commented Jan 30, 2019 •
edited

Codecov Report

Merging #1447 into development will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1447      +/-   ##
===============================================
- Coverage         62.2%   62.06%   -0.14%     
===============================================
  Files               51       51              
  Lines             1450     1450              
  Branches           181      181              
===============================================
- Hits               902      900       -2     
- Misses             438      439       +1     
- Partials           110      111       +1
Impacted Files Coverage Δ
src/app/speechtotext/speechtotext.component.ts 42.85% <0%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5221a57...4edef72. Read the comment docs.

@subhahu123
Copy link
Contributor Author

@mariobehling @praveenojha33 please review

@subhahu123
Copy link
Contributor Author

@rajvaibhavdubey @shreyanshdwivedi please review this

praveenojha33
praveenojha33 requested changes Feb 1, 2019
View reviewed changes
Copy link
Member

@praveenojha33 praveenojha33 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subhahu123 I do not know how it is working fine for you but I am getting a lot of glitches while running Susper. Currently I am unable to get results therefore I am unable to review it properly. @AakashMallik @shreyanshdwivedi Please review.
Here you can see that top right service box collides with right screen.
image

Also please see your changes in other browsers.

@subhahu123
Copy link
Contributor Author

@praveenojha33 can u please tell some more glitches
I have tries this uc,chrome but i did not find any

@shreyanshdwivedi
Copy link
Member

@subhahu123 at first go I only found the service box alignment an issue, I'll try to find out glitches, if any and let you know

@subhahu123
Copy link
Contributor Author

@praveenojha33 please review

@subhahu123
Copy link
Contributor Author

@simsausaurabh please review

simsausaurabh
simsausaurabh suggested changes Mar 9, 2019
View reviewed changes
Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subhahu123

  1. How did you ensure that nothing breaks or changes due to your changes?
  2. When you make a search query, while the results are being fetched and spinner is shown, result page should not be scrollable.

@praveenojha33 Can you please confirm that while we make a search query, and go back to main page, some of the links at footer are highlighted?

@subhahu123
Copy link
Contributor Author

subhahu123 commented Mar 9, 2019 •
edited

  1. When you make a search query, while the results are being fetched and spinner is shown, result page should not be scrollable.

@simsausaurabh
it's working fine .
please compare it with http://susper-dev.herokuapp.com/
i have checked both .
both r doing the same thing

@subhahu123
Copy link
Contributor Author

@praveenojha33 Can you please confirm that while we make a search query, and go back to main page, some of the links at footer are highlighted?

i think yes

@simsausaurabh
Copy link
Member

@shreyanshdwivedi Lets keep this as a low priority for now. It might break something.

@subhahu123 subhahu123 deleted the patch-26 branch April 5, 2019 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simsausaurabh simsausaurabh simsausaurabh requested changes

@praveenojha33 praveenojha33 praveenojha33 requested changes

@sakshee-19 sakshee-19 sakshee-19 approved these changes

@bhaveshAn bhaveshAn Awaiting requested review from bhaveshAn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing unused Css ( make leaned css )
5 participants
@subhahu123 @shreyanshdwivedi @simsausaurabh @sakshee-19 @praveenojha33