Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change preprocessor parser to use pyparsing #126

Open
gnikit opened this issue May 20, 2022 · 2 comments
Open

Change preprocessor parser to use pyparsing #126

gnikit opened this issue May 20, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gnikit
Copy link
Member

gnikit commented May 20, 2022

Description
The current preprocessor parser is flimsy and it does not work as expected

Describe the solution you'd like
Use pyparsing https://github.com/pyparsing/pyparsing for parsing the preprocessor instead of the manual parsing

@gnikit gnikit added the enhancement New feature or request label May 20, 2022
@gnikit gnikit self-assigned this May 20, 2022
@cafhach
Copy link

cafhach commented May 30, 2022

Is the speed of pyparsing adequate?

@gnikit
Copy link
Member Author

gnikit commented May 30, 2022

@cafhach I would suspect so. I have no indication that pyparsing would cause any problems, but in general performance is not that important for a language server when you compare it with the maintenance cost of the parser

@gnikit gnikit added the help wanted Extra attention is needed label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants