Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Update how Forseti sends resource/violation data to Security Center #3772

Open
gkowalski-google opened this issue Jul 8, 2020 · 0 comments
Assignees
Labels
module: notifier priority: p3 Desirable enhancement or minor bug fix triaged: yes

Comments

@gkowalski-google
Copy link
Collaborator

gkowalski-google commented Jul 8, 2020

Story

CSCC now supports struct/dictionary objects in the source properties field. Forseti is currently dumping the JSON dictionary to a string and sending that to Security Center. CSCC is moving away from supporting large string values and Forseti needs to use the dictionaries instead.

Proposed Solution

Update the CSCC Notifier to not dump the JSON dictionary to a string in the following places:

Acceptance Criteria

  • Confirm CSCC integration still works and confirm on the backend side that the finding source properties is in a supported state.
@gkowalski-google gkowalski-google added module: notifier priority: p3 Desirable enhancement or minor bug fix triaged: yes labels Jul 8, 2020
@forseti-security forseti-security deleted a comment from auto-comment bot Jul 8, 2020
@gkowalski-google gkowalski-google self-assigned this Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: notifier priority: p3 Desirable enhancement or minor bug fix triaged: yes
Projects
None yet
Development

No branches or pull requests

1 participant