Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Add --version flag to make it quick to determine the version of Forseti running. #2857

Open
joecheuk opened this issue May 28, 2019 · 5 comments
Assignees
Labels
0 - Backlog Issue to be considered at some point in the future Beginner Easy-level issues for ramping on development in Forseti. module: client triaged: yes type: feature-request

Comments

@joecheuk
Copy link
Contributor

maybe we can include --version flag to show the version.

@dekuhn dekuhn changed the title Make forseti version easier to access Add --version flag to make it quick to determine the version of Froseti running. May 29, 2019
@red2k18
Copy link
Contributor

red2k18 commented Jun 3, 2019

Is this really needed? Version can currently be viewed on Stackdriver logging.

@red2k18 red2k18 added 0 - Backlog Issue to be considered at some point in the future type: feature-request triaged: yes module: client labels Jun 3, 2019
@blueandgold blueandgold changed the title Add --version flag to make it quick to determine the version of Froseti running. Add --version flag to make it quick to determine the version of Forseti running. Aug 6, 2019
@blueandgold blueandgold added the Beginner Easy-level issues for ramping on development in Forseti. label Aug 6, 2019
@garrettwong garrettwong self-assigned this Sep 24, 2019
@ghost
Copy link

ghost commented Oct 7, 2019

Is this still up for grabs

@red2k18
Copy link
Contributor

red2k18 commented Oct 7, 2019

@garrettwong are you working on this?

@garrettwong
Copy link
Collaborator

@TravisDavis-ops TravisDavis-ops - sorry for the delayed response, feel free to take this. If not, I'll revisit in a week.

@gkowalski-google
Copy link
Collaborator

gkowalski-google commented Jul 28, 2020

This was merged in, but does not appear to be working:

Traceback (most recent call last):
  File "/usr/local/bin/forseti", line 11, in <module>
    load_entry_point('forseti-security==2.25.1', 'console_scripts', 'forseti')()
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.25.1-py3.6.egg/google/cloud/forseti/stubs.py", line 34, in RunForsetiCli
    forseti_cli.main()
  File "/usr/local/lib/python3.6/dist-packages/forseti_security-2.25.1-py3.6.egg/google/cloud/forseti/services/cli.py", line 1232, in main
    services[config.service](client, config, output, config_env)
TypeError: run_version() takes 0 positional arguments but 4 were given

@gkowalski-google gkowalski-google added this to the Forseti Operations milestone Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0 - Backlog Issue to be considered at some point in the future Beginner Easy-level issues for ramping on development in Forseti. module: client triaged: yes type: feature-request
Projects
None yet
Development

No branches or pull requests

5 participants