Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some breaking changes 2.0.0 --> 2.0.2 in React 16.13.0 -- Maximum update depth exceeded. #420

Open
vitaliyhayda opened this issue Mar 4, 2020 · 3 comments
Open

Some breaking changes 2.0.0 --> 2.0.2 in React 16.13.0 -- Maximum update depth exceeded. #420

vitaliyhayda opened this issue Mar 4, 2020 · 3 comments
Labels
bug pull request wanted

Comments

@vitaliyhayda
Copy link

Screen Shot 2020-03-04 at 07 30 21

2.0.2 breaks in React 16.13.0, while everything works with formsy-react 2.0.0 in React 16.13.0
@rkuykendall
Copy link
Member

rkuykendall commented Mar 4, 2020 •
edited

Thank you for reporting this!

All changes from 2.0.0 to 2.0.2: 0c681fd...838cfbd

There's a lot in here, but we can ignore test, type, dist, and build changes, so that narrows it down a lot. Reading through the list though, I'm not seeing any clear suspects. Does this happen on mount or when you do something?

@vitaliyhayda
Copy link
Author

On mount

@felixmosh
Copy link
Contributor

@vitaliyhayda Can you reproduce your form using codesandbox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pull request wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rkuykendall @vitaliyhayda @felixmosh