Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from util.isArray #563

Open
marco-ippolito opened this issue Apr 30, 2024 · 0 comments · May be fixed by #564
Open

Move away from util.isArray #563

marco-ippolito opened this issue Apr 30, 2024 · 0 comments · May be fixed by #564

Comments

@marco-ippolito
Copy link

marco-ippolito commented Apr 30, 2024 •
edited

With the new Node.js 22 release, we have runtime deprecated util.isArray and in node 23 we plan to completely remove it.

form-data/lib/form_data.js

Line 64 in 53adbd8

if (util.isArray(value)) {

This line of code will cause failure in consumers of this package like fastify.
nodejs/node#52744 (comment)
I'll create a PR to help migrating util.isArray to Array.isArray
@marco-ippolito marco-ippolito linked a pull request Apr 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move util.isArray to Array.isArray marco-ippolito/form-data
1 participant
@marco-ippolito