Use ServiceEntityRepository #3395
Conversation
Because I'm tired of reinstalling when switching between Fork CMS 5 and 6
carakas
force-pushed
the
refactor-repositories
branch
from
b86032e
to
da8af01
Compare
Codecov Report
@@ Coverage Diff @@
## restructure-core #3395 +/- ##
======================================================
+ Coverage 32.97% 33.04% +0.06%
- Complexity 8814 8833 +19
======================================================
Files 666 666
Lines 32478 32514 +36
======================================================
+ Hits 10711 10744 +33
- Misses 21767 21770 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -314,8 +314,8 @@ services: | |||
| public: true | |||
| arguments: | |||
| - "@fork.settings" | |||
| - "@ForkCMS\\Google\\TagManager\\DataLayer" | |||
| - "@ForkCMS\\Privacy\\ConsentDialog" | |||
| - '@ForkCMS\Google\TagManager\DataLayer' | |||
There was a problem hiding this comment.
' or " ? Should we decide on one format? (the line above is inconsistent - "@fork.settings")
There was a problem hiding this comment.
Doing that in the symfony 5 branch
| @@ -10,14 +10,14 @@ services: | |||
| - "80:80" | |||
| - "443:443" | |||
| depends_on: | |||
| - db | |||
| - db6 | |||
There was a problem hiding this comment.
c7be020 nope, did this on purpose.
We can change it when merging in master but this makes switching between branches during development way easier
| - Common\Doctrine\Entity\Meta | ||
| Common\Doctrine\Entity\CreateSchema: | ||
|
|
||
| Common\Doctrine\Repository\MetaRepository: |
There was a problem hiding this comment.
Should we define an alias so modules can still use 'fork.repository.meta'? Or just break forward with Fork v6?
There was a problem hiding this comment.
I would do a break here.
It is way cleaner to use these type of service name.
Unless we make these private and where needed things like fork.repository.meta public.
| @@ -1,2 +1,3 @@ | |||
| data/ | |||
| * | |||
Type
Fixes
closes #3298
Pull request description
Switch all repositories over to the ServiceEntityRepository for easy autowiring