Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is not possible to make an image in the editor a link #2677

Closed
bramds opened this issue Nov 14, 2018 · 4 comments · Fixed by #3478
Closed

It is not possible to make an image in the editor a link #2677

bramds opened this issue Nov 14, 2018 · 4 comments · Fixed by #3478
Assignees
@carakas
Milestone
5.11.1

Comments

@bramds
Copy link
Contributor

bramds commented Nov 14, 2018 •
edited by carakas

Type

  • Non critical bug

Problem description

Turning an image inserted in an editor into a link doesn't work

Steps to reproduce

  • add image to editor field ( example through medialibrary )
  • select image + click link icon and add a link
  • error msg is shown

Expected behavior / Proposed solutions

expected the image to be clickable to the desired link
@carakas carakas added this to the 5.4.2 milestone Dec 19, 2018
@carakas carakas assigned carakas and unassigned carakas Dec 19, 2018
@carakas carakas modified the milestones: 5.4.2, 5.5.1 Dec 19, 2018
@carakas
Copy link
Member

carakas commented Dec 19, 2018

Going to bump this one to the next release. If anybody wants to give it a try: go ahead

@carakas carakas self-assigned this Mar 12, 2019
@carakas
Copy link
Member

carakas commented Mar 12, 2019 •
edited

Seems to be a bug in CKEditor, you can bypass it by adding the link first with a dummy text, adding the image in the link and then remove the dummy text might have been wrong, looking into it

@carakas carakas closed this as completed Mar 12, 2019
@carakas carakas removed this from the 5.5.1 milestone Mar 12, 2019
@carakas carakas removed the Won't fix label Mar 12, 2019
@carakas carakas reopened this Mar 12, 2019
@carakas carakas added this to the 5.5.1 milestone Mar 12, 2019
@carakas carakas mentioned this issue Mar 12, 2019
Merged
@carakas
Copy link
Member

carakas commented Mar 12, 2019

There is a bug in src/Backend/Core/Js/ckeditor/plugins/medialibrary/dialogs/linkDialog.js but I haven't been able to fix it yet. If somebody else would be able to fix it it would be great

@carakas carakas modified the milestones: 5.5.1, 5.6.1 Mar 13, 2019
@carakas carakas pinned this issue Mar 13, 2019
@carakas carakas modified the milestones: 5.6.1, 5.6.2 Jul 24, 2019
@carakas carakas modified the milestones: 5.6.2, 5.6.3 Aug 14, 2019
@carakas carakas modified the milestones: 5.6.3, 5.6.4 Oct 3, 2019
@carakas carakas modified the milestones: 5.8.0, 5.8.1 Mar 3, 2020
@carakas carakas modified the milestones: 5.8.1, 5.8.2 Apr 17, 2020
@carakas carakas removed this from the 5.8.2 milestone May 12, 2020
@carakas carakas added this to the 5.8.3 milestone May 12, 2020
@carakas carakas modified the milestones: 5.8.3, 5.8.4 Jul 4, 2020
@carakas carakas modified the milestones: 5.9.2, 5.9.3 Dec 5, 2020
@carakas carakas mentioned this issue Jan 18, 2021
Closed
@carakas
Copy link
Member

carakas commented Jan 18, 2021

Steps to reproduce

See video: https://jmp.sh/hd6efy8

@carakas carakas modified the milestones: 5.9.3, 5.10.0 Mar 21, 2021
@carakas carakas modified the milestones: 5.10.0, 5.11.0 May 3, 2021
@carakas carakas mentioned this issue Oct 25, 2021
Closed
@jonasdekeukelaere jonasdekeukelaere mentioned this issue Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carakas carakas

Labels
None yet
Projects
None yet
Milestone
5.11.1
Development

Successfully merging a pull request may close this issue.

Fix adding links to images in ckeditor jonasdekeukelaere/forkcms
2 participants
@bramds @carakas