Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG not updated for v3 (and v2 tags don't exist) #1087

Open
saibotsivad opened this issue May 29, 2020 · 4 comments
Open

CHANGELOG not updated for v3 (and v2 tags don't exist) #1087

saibotsivad opened this issue May 29, 2020 · 4 comments

Comments

@saibotsivad
Copy link

I see that @kibertoad published a major version bump (v2 -> v3) just 7 days ago, but there is nothing in the CHANGELOG so I'm not sure what caused the major version bump.

I wanted to try to look up the diff manually, but there's no v2 release and no v2 tag. 😞

Looks like the v2 version bump is here which means you could make the v2 tag with:

git tag -a v2.0.0 e520b56
git push origin --tags

In order to create a CHANGELOG entry, the diff is available here.

@saibotsivad
Copy link
Author

Actually, I think maybe this is a more accurate diff: dda79a6...master

@saibotsivad
Copy link
Author

The diff suggests to me that the major version bump may have been unnecessary, which makes me worry that I'm not noticing a change that could actually break something.

It would be great if the CHANGELOG could be kept up to date for this module, so users of it could have clearer upgrade paths. 😞

@kibertoad
Copy link
Contributor

See https://github.com/foreversd/forever/blob/master/CHANGELOG.md, it is currently up-to-date.
I believe both semver major changes were related to dropping older Node versions.

@saibotsivad
Copy link
Author

I'm glad to see the changelog finally updated, that's helpful. I'm going to leave this issue open, because I still don't see the 3.0.2-3.0.4 releases in the tags, which means I have to manually dig through commit logs to try to guess at what the git diff is between releases--it seems like there's still some process flow issue in making releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants