Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include @sa11y/jest setup in sfdx force:project:create command #463

Open
albarivas opened this issue Oct 23, 2020 · 4 comments
Open

Include @sa11y/jest setup in sfdx force:project:create command #463

albarivas opened this issue Oct 23, 2020 · 4 comments
Labels

Comments

@albarivas
Copy link

This is an idea to encourage developers to write accessibility unis tests and thus comply with the accessibility best practices that sa11y is able to detect. We could include @sa11y/jest (https://github.com/salesforce/sa11y/tree/master/packages/jest) as a dependency in package.json and also create the needed config files for its initial setup when using the Salesforce CLI command that creates the basic structure of a project.

Find an example of what needs to be included here:

https://github.com/trailheadapps/visualforce-to-lwc/blob/master/package.json
https://github.com/trailheadapps/visualforce-to-lwc/blob/master/jest.config.js
https://github.com/trailheadapps/visualforce-to-lwc/blob/master/jest-sa11y-setup.js

@amphro amphro added the feature label Oct 30, 2020
@amphro
Copy link
Contributor

amphro commented Oct 30, 2020

The code for project:create lives at https://github.com/forcedotcom/salesforcedx-templates

I'll let @lcampos and @ntotten - thoughts?

@lcampos
Copy link
Contributor

lcampos commented Nov 4, 2020

That's a good idea, how stable is that library and who is maintaining it ? Is it a side project or is there an actual team at Salesforce who owns it ?

@mohanraj-r
Copy link
Contributor

Thanks @amphro @lcampos

The @sa11y/jest library has been out for about 6 months. It is being used by many teams in Salesforce. The API is pretty stable - we don't expect it to change significantly in the near future (even if it does in the far future it would follow semantic versioning).
It is backed by the accessibility team at Salesforce (I am currently the primary developer working on it).

@mshanemc
Copy link
Contributor

Closing the issue here. Further discussion/PRs belong at https://github.com/forcedotcom/salesforcedx-templates

@mohanraj-r mohanraj-r reopened this Mar 10, 2022
@mohanraj-r mohanraj-r transferred this issue from forcedotcom/cli Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants