Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid use of incomplete type 'struct lexyd::_capt on use of scanner::capture_token #200

Closed
Spartan322 opened this issue May 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Spartan322
Copy link

No description provided.

@foonathan
Copy link
Owner

Are you including <lexy/dsl.hpp> (or specifically <lexy/dsl/capture.hpp>)?

@Spartan322
Copy link
Author

Spartan322 commented May 12, 2024

Yes, I believe the issue is that the _capt struct was renamed to _cap at some point, I can't find the definition for _capt anywhere in the code base but looking through the history when

struct _capt;
was added in the codebase it seemed to refer to a struct that's fairly similar to what _cap now is.

The change happened in 84161b0 but I don't see scan.hpp there so the change seems to have flown under the radar, I presume, given the content of that commit, it was meant to be removed?

@foonathan foonathan added the bug Something isn't working label May 13, 2024
@foonathan
Copy link
Owner

Oh, good catch!

Yes, I forgot about scanner when doing that change. I think the correct approach would be to mirror the behavior: remove .capture and rename .capture_token to .capture (and change _capt -> _cap). I can fix that later this week, but you can also do a PR if you want to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants