Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css] vertical margin #2928

Open
mvorisek opened this issue Oct 14, 2023 · 2 comments
Open

[css] vertical margin #2928

mvorisek opened this issue Oct 14, 2023 · 2 comments
Labels
type/discussion Anything which is up for discussion

Comments

@mvorisek
Copy link
Contributor

mvorisek commented Oct 14, 2023

Bug Report

I am not sure about the correct vertical margin nor how the fix will affect other styles.

Maybe more inline components than buttons need to be fixed. In theory, any inline compoennt can wrap, so when the background is set, the top or bottom margin must be > 0.

Steps to reproduce

https://jsfiddle.net/t6p2bn8c/1/

Expected result

image

Actual result

image

Version

2.9.3

@mvorisek mvorisek added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Oct 14, 2023
@ko2in
Copy link
Member

ko2in commented Oct 15, 2023

There is already spaced buttons group.

@ko2in ko2in removed the state/awaiting-triage Any issues or pull requests which haven't yet been triaged label Oct 15, 2023
@lubber-de
Copy link
Member

lubber-de commented Oct 15, 2023

What @ko2in said.. We implemented wrapping and spaced to handle at least button groups via #2217
Unfortunately you cannot detect if inline elements are actually wrapped via pure CSS.

@lubber-de lubber-de added type/discussion Anything which is up for discussion and removed type/bug Any issue which is a bug or PR which fixes a bug state/awaiting-investigation Anything which needs more investigation labels Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/discussion Anything which is up for discussion
Projects
None yet
Development

No branches or pull requests

3 participants