Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text drawing broken since introduction of text scaling transform #159

Open
marco-m opened this issue Jan 23, 2022 · 1 comment
Open

text drawing broken since introduction of text scaling transform #159

marco-m opened this issue Jan 23, 2022 · 1 comment

Comments

@marco-m
Copy link

marco-m commented Jan 23, 2022

Hello @fogleman, thanks for gg!

If I run examples/quadratic.go I get

image

The image is created correctly at commit 15eec45 (when examples/quadratic.go was introduced):

image

I then ran a git bisect and got:

2c35caba582611ac0393cc589134cc293a2a0782 is the first bad commit
commit 2c35caba582611ac0393cc589134cc293a2a0782
Author: wsw <wsw0108@gmail.com>
Date:   Sun Jan 8 16:23:33 2017 +0800

    apply current matrix when draw text

 context.go               | 29 +++++++++++++++++++++++++----
 examples/rotated-text.go | 30 ++++++++++++++++++++++++++++++
 2 files changed, 55 insertions(+), 4 deletions(-)
 create mode 100644 examples/rotated-text.go

For reference, it is PR #16.

@fogleman
I was also thinking: if the various out.png of the examples directory normally do not change, then we could add a CI step that runs all the examples and compares the corresponding out.png (purely as a binary comparison), what is normally called golden files, and fail the CI if any file differs. I would be then up to the committer to decide if there is a real reason for the change, and at this point the PR would contain also the updated out.png.

@marco-m
Copy link
Author

marco-m commented Feb 10, 2022

Hello @wsw0108, any ideas how what could have caused this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant