Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use setuptools scripts, use console_scripts entry point. #33

Open
KOLANICH opened this issue Feb 13, 2023 · 2 comments
Open

Don't use setuptools scripts, use console_scripts entry point. #33

KOLANICH opened this issue Feb 13, 2023 · 2 comments

Comments

@KOLANICH
Copy link
Contributor

No description provided.

@lorenzosaino
Copy link
Member

If you have any thoughts on what changes need to happen, I'd be happy to accept pull requests. Otherwise, please share more details about the issue and I will look into it.

@KOLANICH
Copy link
Contributor Author

  1. scripts python files should be moved from bin dir into the main package, for example into fnss.cli
  2. each of them should have a function to call. The block should look like
if __name__ == "__main__":
    main()

with nothing else inside

  1. remove scripts keyword and add
entry_points={"console_scripts":{
"fnss-troubleshoot": "fnss.cli.troubleshoot:main",
'bin/mn-fnss': "fnss.cli.mn:main",
}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants