Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish unreleased changes #541

Closed
aduth opened this issue Jan 11, 2024 · 3 comments
Closed

Publish unreleased changes #541

aduth opened this issue Jan 11, 2024 · 3 comments

Comments

@aduth
Copy link

aduth commented Jan 11, 2024

Description

There are a couple changes slated for release (see CHANGELOG.md) which have been merged for multiple years. We particularly have an interest in using the new chromium_based? method. Would you please consider publishing a new release containing these changes?

How to reproduce

require 'browser'
Browser.new('some user agent').chromium_based?

What do you expect

false

What happened instead

undefined method `chromium_based?' for #<Browser::Unknown ...> (NoMethodError)

Software:

  • Browser gem version: 5.3.1
@aduth
Copy link
Author

aduth commented Jan 11, 2024

I think a workaround given the current implementation is:

browser.chrome? || browser.edge?

On that note, there may be other browsers that should also be considered as Chromium based? Being able to use the chromium_based? abstraction would be preferable to checking individual browsers to allow for changes over time.

@fnando
Copy link
Owner

fnando commented Apr 30, 2024

just released v6.0.0.

@fnando fnando closed this as completed Apr 30, 2024
@aduth
Copy link
Author

aduth commented May 1, 2024

Thank you for releasing the new version! And for maintaining this useful gem ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants