Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong reporting with old images with higher semver version #335

Open
matheusvellone opened this issue Dec 29, 2023 · 2 comments
Open

Wrong reporting with old images with higher semver version #335

matheusvellone opened this issue Dec 29, 2023 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@matheusvellone
Copy link

Thanks for the project, really helpful!

I'm using linuxserver/qbittorrent on DockerHub registry pinned to version 4.6.2, the latest one, but WUD keeps reporting there's a new version 20.04.1
I can see that this version does exists in DockerHub, but it's from 2 years ago.

Screenshots

image
image
image

Looks like WUD is comparing images using semver logic, but in this case looks like there was a older way to version images, which changed later (maybe).

Maybe it would safer if WUD compares the publish data instead of simple semver logic, but I don't know if this information is available somehow.

@fmartinou
Copy link
Owner

Unfortunately for you, WUD logic is right in this case.
I cannot base the comparison on the "publish date" because some image providers are rebuilding old images after having push newer versions so semver comparison is the most reliable way to compare versions.

The only easy way I see to get around it is to include more precise wud.tag.include or wud.tag.exclude regex to filter these "20.x" false positive matches.

@fmartinou fmartinou self-assigned this Jan 24, 2024
@fmartinou fmartinou added the help wanted Extra attention is needed label Jan 24, 2024
@matheusvellone
Copy link
Author

Sure, this is a corner case bc this image switched versioning strategies 😕

I cannot base the comparison on the "publish date" because some image providers are rebuilding old images after having push newer versions so semver comparison is the most reliable way to compare versions.

Indeed, this would cause more trouble. But what if WUD checks both semver AND publish date? Wouldn't this solve this case and avoiding creating a new one? Also, this looks intuitive to me

The only easy way I see to get around it is to include more precise wud.tag.include or wud.tag.exclude regex to filter these "20.x" false positive matches.

Ended up doing this, solved the problem, but if WUD could take care of this kind of problem, this would fell less hacky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants