Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core feature] limit-namespace should be a limit-namespaces to accept list of namespaces #5181

Open
2 tasks done
MortalHappiness opened this issue Apr 4, 2024 · 2 comments · May be fixed by #5342
Open
2 tasks done

[Core feature] limit-namespace should be a limit-namespaces to accept list of namespaces #5181

MortalHappiness opened this issue Apr 4, 2024 · 2 comments · May be fixed by #5342
Assignees
@MortalHappiness
Labels
backlogged For internal use. Reserved for contributor team workflow. enhancement New feature or request

Comments

@MortalHappiness
Copy link
Contributor

MortalHappiness commented Apr 4, 2024 •
edited

Motivation: Why do you think this is important?

As @ByronHsu mentioned in #5087 (comment), now the limit-namespace config only accepts a single namespace. It should be a list of strings to accept multiple namespaces instead of only a single namespace.

Goal: What should the final outcome look like, ideally?

Rename limit-namespace to limit-namespaces and change its type from string to []string

Describe alternatives you've considered

N/A

Propose: Link/Inline OR Additional context

This issue depends on #5087

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@MortalHappiness MortalHappiness added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Apr 4, 2024
@MortalHappiness
Copy link
Contributor Author

#take

@dosubot DosuBot
Copy link

dosubot bot commented Apr 4, 2024 •
edited

Hey @MortalHappiness! 🚀

I've thoroughly reviewed your suggestion regarding the limit-namespace configuration, and I must say, it's a solid idea that aligns well with the flexibility and scalability we aim for. Renaming limit-namespace to limit-namespaces and changing its type from string to []string would indeed enhance the functionality and user experience.

Given the dependency on #5087, I'll ensure to keep a close eye on that issue's progress to align our updates accordingly. Your initiative to propose this enhancement is highly appreciated, and it's clear you've done your homework by ensuring this issue hasn't been raised before and adhering to our Code of Conduct.

I'll start drafting the necessary changes and plan out the implementation strategy. Your insight has been invaluable, and I look forward to seeing this improvement come to life. If you have any more suggestions or need further clarification, feel free to reach out.

Thanks for contributing to making our project even better! 🌟

Best,
Dosu

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@eapolinario eapolinario added backlogged For internal use. Reserved for contributor team workflow. and removed untriaged This issues has not yet been looked at by the Maintainers labels Apr 4, 2024
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue May 9, 2024
@MortalHappiness
feat(propeller): Support multiple namespaces for limit-namespace
fcb0598 
Resolves: flyteorg#5181
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness linked a pull request May 9, 2024 that will close this issue
Open
3 tasks
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue May 11, 2024
@MortalHappiness
feat(propeller): Support multiple namespaces for limit-namespace
a3e2cfc 
Resolves: flyteorg#5181
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness added a commit to MortalHappiness/flyte that referenced this issue May 17, 2024
@MortalHappiness
feat(propeller): Support multiple namespaces for limit-namespace
217288f 
Resolves: flyteorg#5181
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MortalHappiness MortalHappiness

Labels
backlogged For internal use. Reserved for contributor team workflow. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(propeller): Support multiple namespaces for limit-namespace MortalHappiness/flyte
2 participants
@eapolinario @MortalHappiness