feat(bindings): Task arguments default value binding #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortalHappiness
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
MortalHappiness
force-pushed
the
feature/#5321-task-default-value-binding
branch
from
b434ddf
to
cc13415
Compare
pingsutw
reviewed
May 14, 2024
| @@ -46,6 +46,14 @@ def t2(a: typing.Optional[int] = None) -> typing.Optional[int]: | |||
| assert p.ref.var == "o0" | |||
| assert len(p.ref.node.bindings) == 0 | |||
|
|
|||
| @task | |||
| def t_default_value(a: int = 1) -> typing.Optional[int]: | |||
There was a problem hiding this comment.
Could you also add a test like below?
@task
def。t_default_value(a: int = 1) -> typing.Optional[int]:
return a
@workflow
def wf() -> typing.Optional[int]:
return t_default_value(a=2)I want to make sure the output of the workflow is 2
MortalHappiness
force-pushed
the
feature/#5321-task-default-value-binding
branch
from
cc13415
to
277d88b
Compare
Done |
MortalHappiness
force-pushed
the
feature/#5321-task-default-value-binding
branch
2 times, most recently
from
51e15e5
to
6446ad1
Compare
|
could you add more tests please? take a look at serialization tests, it should be pretty simple to test the compiled workflow. do we do anything special for [] and {}? You're not supposed to use those as function defaults anyways but some people might. |
Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Resolves: flyteorg/flyte#5321 Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
MortalHappiness
force-pushed
the
feature/#5321-task-default-value-binding
branch
from
6446ad1
to
6c808ae
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Resolves: flyteorg/flyte#5321
Why are the changes needed?
See the issue description for details.
What changes were proposed in this pull request?
if the key is not in
kwargsbut ininterface.inputs_with_defaults, add the value ininterface.inputs_with_defaultstokwargs.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link