Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Flytekit should support unsafe mode for types #5319

Open
2 tasks done
kumare3 opened this issue May 3, 2024 · 2 comments
Open
2 tasks done

[Core feature] Flytekit should support unsafe mode for types #5319

kumare3 opened this issue May 3, 2024 · 2 comments
Assignees
Labels
backlogged For internal use. Reserved for contributor team workflow. enhancement New feature or request flytekit FlyteKit Python related issue untriaged This issues has not yet been looked at by the Maintainers

Comments

@kumare3
Copy link
Contributor

kumare3 commented May 3, 2024

Motivation: Why do you think this is important?

Today for every task and workflow it is necessary for everything to be typed. It should be possible to create tasks that are untyped and unsafe optionally

Goal: What should the final outcome look like, ideally?

@task(unsafe=True)
def foo(x, y: int) -> typing.Any:
   ...

@task
def foo2(y: int):
   ...

@workflow(unsafe=True)
def wf(x, y: int):
   foo(x=x, y=10)
   foo1(y=y)

Describe alternatives you've considered

everything can be marked as typing.Any today, which is but a problem

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@kumare3 kumare3 added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels May 3, 2024
@kumare3
Copy link
Contributor Author

kumare3 commented May 3, 2024

FlytePickle => FlyteFile[pickle]
FlytePickle = Optional[FlyteFile, Binary].  # Union type

@Mecoli1219
Copy link

#take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. enhancement New feature or request flytekit FlyteKit Python related issue untriaged This issues has not yet been looked at by the Maintainers
Projects
None yet
Development

No branches or pull requests

3 participants