Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM support #414

Closed
VictorGrycuk opened this issue Feb 24, 2024 · 15 comments · Fixed by #424
Closed

ARM support #414

VictorGrycuk opened this issue Feb 24, 2024 · 15 comments · Fixed by #424
Assignees
@sadok-f
Labels
enhancement version 1
Milestone
Version 1.3

Comments

@VictorGrycuk
Copy link

Hi, I would like to know if you plan to support Arm devices. I would love to run it on my Raspberry Pi.

Thanks!
@sadok-f
Copy link
Member

sadok-f commented Feb 25, 2024

Hi @VictorGrycuk,

Thank you for bringing this up, we're working on it and we'll update the docker images accordingly.

@sadok-f sadok-f self-assigned this Feb 25, 2024
@sadok-f sadok-f added this to the Version 1.3 milestone Feb 25, 2024
sadok-f added a commit that referenced this issue Feb 25, 2024
@sadok-f
fix: add Multi-platform image with GitHub Actions, #414
2ab0d07
@sadok-f sadok-f mentioned this issue Feb 25, 2024
Merged
sadok-f added a commit that referenced this issue Feb 25, 2024
@sadok-f
Merge pull request #415 from flyimg/issue#414
f79ab8b 
fix: add Multi-platform image with GitHub Actions, #414
sadok-f pushed a commit that referenced this issue Feb 25, 2024
@semantic-release-bot
chore(release): 1.3.3 [skip ci]
a1f2bd3 
## [1.3.3](1.3.2...1.3.3) (2024-02-25)

### Bug Fixes

* add Multi-platform image with GitHub Actions, [#414](#414) ([2ab0d07](2ab0d07))
@VictorGrycuk
Copy link
Author

Awesome, thanks!

sadok-f pushed a commit that referenced this issue Feb 25, 2024
@semantic-release-bot
chore(release): 1.3.3 [skip ci]
1dbe1d7 
## [1.3.3](1.3.2...1.3.3) (2024-02-25)

### Bug Fixes

* add Multi-platform image with GitHub Actions, [#414](#414) ([2ab0d07](2ab0d07))
* fixing linting errors ([f414470](f414470))
* fixing missing PLATFORM_PAIR for the articat upload (Github Action CD) ([84b55ff](84b55ff))
* fixing Multi-platform image with GitHub Actions ([ce62db0](ce62db0))
* fixing the base image path ([954ff76](954ff76))
* fixing the REGISTRY_IMAGE tags ([eb3d09b](eb3d09b))
* fixing typo in docker Create manifest list and push step ([5a7658b](5a7658b))
sadok-f pushed a commit that referenced this issue Feb 25, 2024
@semantic-release-bot
chore(release): 1.3.3 [skip ci]
09c743a 
## [1.3.3](1.3.2...1.3.3) (2024-02-25)

### Bug Fixes

* add Multi-platform image with GitHub Actions, [#414](#414) ([2ab0d07](2ab0d07))
* fixing linting errors ([f414470](f414470))
* fixing missing PLATFORM_PAIR for the articat upload (Github Action CD) ([84b55ff](84b55ff))
* fixing Multi-platform image with GitHub Actions ([ce62db0](ce62db0))
* fixing the base image path ([954ff76](954ff76))
* fixing the REGISTRY_IMAGE tags ([eb3d09b](eb3d09b))
* fixing typo in docker Create manifest list and push step ([5a7658b](5a7658b))
* fixing workflow release issue ([7864655](7864655))
sadok-f pushed a commit that referenced this issue Feb 25, 2024
@semantic-release-bot
chore(release): 1.3.3 [skip ci]
c3f4878 
## [1.3.3](1.3.2...1.3.3) (2024-02-25)

### Bug Fixes

* add Multi-platform image with GitHub Actions, [#414](#414) ([2ab0d07](2ab0d07))
* fixing Create manifest list stage: ([91524d3](91524d3))
* fixing linting errors ([f414470](f414470))
* fixing missing PLATFORM_PAIR for the articat upload (Github Action CD) ([84b55ff](84b55ff))
* fixing Multi-platform image with GitHub Actions ([ce62db0](ce62db0))
* fixing the base image path ([954ff76](954ff76))
* fixing the REGISTRY_IMAGE tags ([eb3d09b](eb3d09b))
* fixing typo in docker Create manifest list and push step ([5a7658b](5a7658b))
* fixing workflow release issue ([7864655](7864655))
sadok-f pushed a commit that referenced this issue Feb 26, 2024
@semantic-release-bot
chore(release): 1.3.3 [skip ci]
1e0b603 
## [1.3.3](1.3.2...1.3.3) (2024-02-26)

### Bug Fixes

* add Multi-platform image with GitHub Actions, [#414](#414) ([2ab0d07](2ab0d07))
* fixing Create manifest list stage: ([91524d3](91524d3))
* fixing github workflow ([5aff78a](5aff78a))
* fixing linting errors ([f414470](f414470))
* fixing missing PLATFORM_PAIR for the articat upload (Github Action CD) ([84b55ff](84b55ff))
* fixing Multi-platform image with GitHub Actions ([ce62db0](ce62db0))
* fixing the base image path ([954ff76](954ff76))
* fixing the REGISTRY_IMAGE tags ([eb3d09b](eb3d09b))
* fixing typo in docker Create manifest list and push step ([5a7658b](5a7658b))
* fixing workflow release issue ([7864655](7864655))
@sadok-f sadok-f mentioned this issue Feb 26, 2024
Merged
sadok-f pushed a commit that referenced this issue Feb 26, 2024
@semantic-release-bot
chore(release): 1.3.3 [skip ci]
2d2320e 
## [1.3.3](1.3.2...1.3.3) (2024-02-26)

### Bug Fixes

* add Multi-platform image with GitHub Actions, [#414](#414) ([2ab0d07](2ab0d07))
* fixing Create manifest list stage: ([91524d3](91524d3))
* fixing Github Action workflow for Multi-platform Docker image ([1d0e144](1d0e144))
* fixing github workflow ([5aff78a](5aff78a))
* fixing linting errors ([f414470](f414470))
* fixing missing PLATFORM_PAIR for the articat upload (Github Action CD) ([84b55ff](84b55ff))
* fixing Multi-platform image with GitHub Actions ([ce62db0](ce62db0))
* fixing the base image path ([954ff76](954ff76))
* fixing the REGISTRY_IMAGE tags ([eb3d09b](eb3d09b))
* fixing typo in docker Create manifest list and push step ([5a7658b](5a7658b))
* fixing workflow release issue ([7864655](7864655))
@sadok-f
Copy link
Member

sadok-f commented Feb 26, 2024

@VictorGrycuk
can you try out the latest docker image?
flyimg/flyimg-build:latest or flyimg/flyimg-build:1.3.3

thx

@VictorGrycuk
Copy link
Author

Thanks @sadok-f.
Sadly, it's not working. I get the following after running the build 1.3.3:

exec /usr/local/bin/docker-entrypoint: exec format error

Could it be that its missing the arm/v8 platform? I am using an RP 4 with aarch64 GNU/Linux.

@sadok-f
Copy link
Member

sadok-f commented Feb 27, 2024 •
edited

interesting, let me add the linux/arm64/v8 platform then.

@sadok-f sadok-f reopened this Feb 27, 2024
@sadok-f
Copy link
Member

sadok-f commented Feb 27, 2024

ok, can you try thew new version flyimg/flyimg-build:1.3.4 ?

@VictorGrycuk
Copy link
Author

Thanks @sadok-f, but I am getting the same issue. Trying to build the image locally, I get the following:

 ---> [Warning] The requested image's platform (linux/amd64) does not match the detected
host platform (linux/arm64/v8) and no specific platform was requested

By specifying the platform, I get

image with reference flyimg/base-image:1.4.1 was found but does not match the specified platform:
wanted linux/arm64, actual: linux/amd64

I'll keep troubleshooting it after work.

@sadok-f
Copy link
Member

sadok-f commented Feb 27, 2024

yes, I need to add the multi-arch build to the base image as well, I'll keep you posted.

@sadok-f sadok-f mentioned this issue Mar 4, 2024
Closed
@sadok-f
Copy link
Member

sadok-f commented Mar 4, 2024

quick update here, I'm still trying to build the base image with multi-arch, still blocked by many dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

This issue is stale (30 days with no activity)

@github-actions github-actions bot added the stale label Apr 4, 2024
@sadok-f
Copy link
Member

sadok-f commented Apr 5, 2024

Sorry for the delay here, I'm facing some issues compiling/installing some libraries in the base image for ARM, especially the pip AVIF library.
I'll add more details in the issue I opened in the base-image repo flyimg/base-image#18
any help is appreciated.

@github-actions github-actions bot removed the stale label Apr 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

This issue is stale (30 days with no activity)

@github-actions github-actions bot added the stale label May 6, 2024
sadok-f added a commit that referenced this issue May 9, 2024
@sadok-f
fix: update flyimg base version to support multi arch build, fixing #414
74d6336
@sadok-f sadok-f mentioned this issue May 9, 2024
Merged
sadok-f added a commit that referenced this issue May 9, 2024
@sadok-f
Merge pull request #443 from flyimg/issue#414
baced8f 
fix: update flyimg base version to support multi arch build, fixing #414
sadok-f pushed a commit that referenced this issue May 9, 2024
@semantic-release-bot
chore(release): 1.3.5 [skip ci]
873bf8b 
## [1.3.5](1.3.4...1.3.5) (2024-05-09)

### Bug Fixes

* update flyimg base version to support multi arch build, fixing [#414](#414) ([74d6336](74d6336))
@sadok-f
Copy link
Member

sadok-f commented May 9, 2024 •
edited

Hi @VictorGrycuk , can you try out the latest version (the docker image was renamed as well)
flyimg/flyimg:1.4.0
The base image got updated with a successful build for the arm arch, unfortunately the face detection for avid format will not work, you have to disable avif generation when using face-detection options.
Thanks

@github-actions github-actions bot removed the stale label May 10, 2024
@VictorGrycuk
Copy link
Author

@sadok-f Apologies for the late response.
I just tried the new image, and I was able to run it on the raspberry!

@sadok-f
Copy link
Member

sadok-f commented May 21, 2024

Great, thank you for confirming

@sadok-f sadok-f closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sadok-f sadok-f

Labels
enhancement version 1
Projects
V1 release
Status: No status
Milestone
Version 1.3
Development

Successfully merging a pull request may close this issue.

fix: fixing Github Action workflow for Multi-platform Docker image flyimg/flyimg
2 participants
@sadok-f @VictorGrycuk